ryan 136 points 3 years ago

Let him play in the legacy code. You can just hose him off later before letting him back into the office so he doesn't track it everywhere.

path: 0 4777073, hotness: undefined, score: 136, children: 9

ISometimesAdmin 62 points 3 years ago

Unfortunately if you let Junior play in legacy code once, it'll learn some nasty habits and make more of it from scratch, usually when you're trying to sleep.

save

path: 0 4777073 4777890, hotness: undefined, score: 62, children: 3

Hazzia 18 points 3 years ago

save

path: 0 4777073 4777890 4780072, hotness: undefined, score: 18, children: 1

MonkderZweite 5 points 3 years ago

That's what the line represents. So they can pull you if you do something nasty.

save

path: 0 4777073 4777890 4782207, hotness: undefined, score: 5, children: 0

BaardFigur 15 points 3 years ago

save

path: 0 4777073 4781700, hotness: undefined, score: 15, children: 3

CodeMonkey 10 points 3 years ago

If you are creating an alternative implementation and leaving the old one in place, you are not fixing a problem, you are just creating a new one (and a third one because you have duplication of logic).

Either refactor the old function so that it transparently calls the new logic or delete the old function and replace all the existing usage with usage of the new one. It does not need to happen as a single commit. You can check in the new function, tell everyone to use it, and clean up usage of the old one. If anyone tries to use the old implementation, call them out in a code review.

If removing or replacing the old implementation is not possible, at least mark it as deprecated so that anyone using it gets a warning.

save

path: 0 4777073 4781700 4782314, hotness: undefined, score: 10, children: 2

mbp 4 points 3 years ago

God, I would love that so much

save

path: 0 4777073 4789176, hotness: undefined, score: 4, children: 0

Rules

Rules