Brilliant exception handling I found in an app i had to work on
Brilliant exception handling I found in an app i had to work on
3 years ago by Zadyra to c/programmerhumor
TwilightKiddy 5 points 3 years ago
Rethrowing caught exception in C# is just throw;, not throw ex;. This will delete old stack trace, which is very punishable if someone debugs your code later and you're still around.
CatPoop 1 point 3 years ago
An exception will bubble up the stack until it enters a catch block that can handle it, and you may need additional logic to decide if you are finished, or it needs to go further up. (you may also intercept it just to add more data, or log it)
throw; allows you send the original exception further up, but throw ex; behaves the same as throwing a new Exception object, and therefore has a new trace. The throw statement doesn’t query any properties on the exception argument AFAIK, so it has no idea this exception has been previously thrown, but the IDE is smart enough to know you almost certainly don’t want to do this.
TwilightKiddy 1 point 3 years ago
throw ex; treats ex as a new exception, so, it starts a new stack trace for it from itself and deletes stack trace that was saved in ex.StackTrace. On the other hand, throw; takes already present exception in the scope and throws it without modifying the stack trace, preserving the original method that threw ex in the stack trace.
I feel like I wrote the same thing twice. I'm a bit bad with explaining stuff, feel free to ask more specific questions if you still don't understand the difference.
bigkahuna1986 14 points 3 years ago
I'm offended that you'd put my code on the internet.
relative_iterator 7 points 3 years ago
“I’ll come back to this”
grimmi 13 points 3 years ago
If this is C# (and it looks like it is), this leads to you losing the original stack trace up until this point.
The correct way to do this in C# is to just throw; after you're done with whatever you wanted to do in the catch.
jyte 4 points 3 years ago
wait what ?
So you are saying that the following code will keep throwing e but if I used throw e; it would basically be the same except for the stack trace that would be missing the important root cause ?!
try {
} catch (WhateverException e) {
// stuff, or nothing, or whatever
throw;
}
TwilightKiddy 4 points 3 years ago
Exactly. Aside from deleting your already built stack trace, as a bonus you'll get another stack trace building call, enjoy wasted CPU cycles.
chillhelm 6 points 3 years ago
Depending on the language it either does nothing and just adds code bloat or (and this would be much worse) it will catch any exception that can be implicitly cast to type Exception and throw it as type Exception. So the next higher scope would not be able to catch e.g. a RuntimeException or w.e. to handle appropriately. It could only catch a regular Exception even if the original error was a more detailed type.
StudioLE 5 points 3 years ago
It's C# so it's just rethrowing the original exception.
It might also be messing with the stack trace though which can be a bit frustrating for future debugging. But that's only a vague recollection of something I read in the past so I could be wrong
Pieisawesome 1 point 3 years ago
Throwing exceptions are very costly due to the stack trace, so building the stack trace twice will cause a big performance hit
TwilightKiddy 2 points 3 years ago
Correct me if I'm wrong, but this will actually cut the stack trace and then start another one from your try-catch block, which is an evil thing to do towards those who will actually read your stack traces. To preserve the stack trace you do throw;, not throw ex;, and I'm assuming IDE is underlining that statement exactly for this reason.
EinfachUnersetzlich 2 points 3 years ago
You could just not catch it and it'll get thrown up the stack anyway.
sellingspams -6 points 3 years ago
This can't compile, can it? Only a madman commits code which doesn't compile.
programmerhumor
@lemmy.ml
43751
1627
1186
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
- Posts must be relevant to programming, programmers, or computer science.
- No NSFW content.
- Jokes must be in good taste. No hate speech, bigotry, etc.
go to feed...
programmerhumor
@lemmy.ml
43751
1627
1186
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
- Posts must be relevant to programming, programmers, or computer science.
- No NSFW content.
- Jokes must be in good taste. No hate speech, bigotry, etc.
go to feed...
Actually, exception rethrowing is a real thing - at least in Java. You may not always want to handle the exception at the absolute lowest level, so sometimes you will instead "bubble" the exception up the callstack. This in turn can help with centralizing exception handling, separation of concerns, and making your application more modular.
It seems counter-intuitive but it's actually legit, again at least in Java. lol
save