Happy with my bash progress!

2 years ago by harsh3466 to c/linux

This is just me celebrating a small win. I've been slowly learning bash scripting, and just now I was able to quickly write a simple bash script to automate a file moving task without referring to my notes or the web!

It's not a super complicated script, I'm just happy I'm starting to internalize the knowledge I've been building.

I've been organizing my media files after ripping our DVD collection. I had all the files for The Smurfs cartoon (love the Smurfs) in the main Smurfs show folder. I wanted to put them all into their respective season folders (Season.XX). Here's the script:

#! /bin/bash

for number in {01..09}; do
    find . -type f -name "The.Smurfs.S$number*" -exec mv {} Season.$number/ \;
done

I could have done it as a one liner, but I like to keep things like this for future reference.

load all comments

MonkderVierte 1 point 2 years ago

save

path: 0 15127506, hotness: undefined, score: 1, children: 4

DollyDuller 2 points 2 years ago

If you want to share your script with others, I think it's a good idea to make it as easy to read as possible.

If you're just keeping it for yourself, that's fine. But if you're sharing it with me, the more readable it is, the easier I'll be able to understand what you're trying to do and how you're solving the problem. This will make it easier for us to discuss ideas and improvements together. To be honest, one-liners can be a bit confusing because they can do multiple things at once. Breaking things down into individual steps makes it easier for me to follow along and for you to understand why you made certain decisions.

Plus, it's a good habit to get into for your own future reference - you'll be able to look back and understand your thought process more easily.

As the famous saying from SICP goes:

programs must be written for people to read, and only incidentally for machines to execute

save

path: 0 15127506 15128290, hotness: undefined, score: 2, children: 1

harsh3466 1 point 2 years ago

Agree. Make it as easy to read as possible. I learned this particularly after I had written a script that had a lot of nesting. It worked initially, but not for long and when I went back to debug I was like, "What the fuck was I thinking here?"

I ended up completely rewriting it to minimize the nesting and make it much more efficient and readable

save

path: 0 15127506 15128290 15134921, hotness: undefined, score: 1, children: 0

Rules

Related Communities

Rules

Related Communities