My code review team is skeptical.

10 months ago by dbtng to c/iiiiiiitttttttttttt

Nixie and Larry ain't buying my bullshit. Not enough whitespace.

dbtng 21 points 10 months ago

Getting the cold shoulder here.

(They are actually warm and fuzzy shoulders.)

save

path: 0 20867445, hotness: undefined, score: 21, children: 0

jaybone 15 points 10 months ago

cat | curl && sleep

save

path: 0 20868761, hotness: undefined, score: 15, children: 1

dbtng 2 points 10 months ago

save

path: 0 20868761 20936552, hotness: undefined, score: 2, children: 0

luciferofastora 4 points 10 months ago

Not enough whitespace.

I got to help a colleague debug a powershell script. It contained six SQL queries.

They were each written in a single line and featured double-nested queries and multi-clause conditionals. He didn't use any aliases either.

I'm sure there's a way to auto-format SQL in some tool, but in the moment, I couldn't remember.

Listen to your cats. Use more whitespace.

Also, if they like it, please pet them for me. Good code reviewers deserve pets.

save

path: 0 20903655, hotness: undefined, score: 4, children: 1

dbtng 1 point 10 months ago

Hehe. You are preachin to the choir.
In truth, most of my code, particularly my published pieces, looks like a textbook example of self-documentation.
This is because I'm inexpert enough at coding to need the pointers next time I look at my own code.
So if it looks like a kindergarten teacher authored it, I'll probly be able to understand it later.

And thanks! My kitties always want more scratches. :]

save

path: 0 20903655 20936525, hotness: undefined, score: 1, children: 0

homesweethomeMrL 2 points 10 months ago

Well, it’s an upgrade from rubber-duck code reviews.

save

path: 0 20867825, hotness: undefined, score: 2, children: 0

slazer2au 2 points 10 months ago

Let me guess, one lines tabs the other likes spaces.

save

path: 0 20867324, hotness: undefined, score: 2, children: 0