HubertManne 13 points 3 years ago

I hate places without code review. Makes me nervous as heaven to merge code and want as many double checks as possible.

path: 0 574601, hotness: undefined, score: 13, children: 3

Noumena 2 points 3 years ago

I feel this way about open source and the seemingly frequent lack of detailed code reviews. This one project had two function options to use from a library. One handles errors by returning them to the caller so they can be handled gracefully. The other, calls PANIC! They chose the latter and it causes a crash loop for a relatively easy to hit code condition that is sensitive to User input.

Why ask for unit test, in the code review, when you can just accept the contribution for a feature that is used in large corps.

save

path: 0 574601 575644, hotness: undefined, score: 2, children: 2

HubertManne 2 points 3 years ago

I will say I hate having to pester folks to do review on a merge. The place im currently at requires two and its pulling teeth to get folks to look at someone elses code. well except for me I always treat merges as priority as that is ready to go whereas with mine if I have not merged then its not that ready.

save

path: 0 574601 575644 579050, hotness: undefined, score: 2, children: 0

nightauthor 1 point 3 years ago

Down with the corps?

save

path: 0 574601 575644 582871, hotness: undefined, score: 1, children: 0

Derickdoes 9 points 3 years ago

Found my Senior Engineer

save

path: 0 572565, hotness: undefined, score: 9, children: 0

rodhlann 7 points 3 years ago

I hate code reviews because for whatever stupid reason my brain decides this is how it is.

I was at an XP shop for a few years before my current job and I forgot how much I hate code reviews because we were constantly pairing and didn't do reviews in the same way. Coming back to the standard sort of code review model has been torture.

save

path: 0 573920, hotness: undefined, score: 7, children: 0

sentient_loom 5 points 3 years ago

When I do code reviews it is a personal attack. I only suggest code changes on my enemy's pull requests.

save

path: 0 575442, hotness: undefined, score: 5, children: 0

AnarchoGravyBoat 3 points 3 years ago

@Lenguador

Code reviews are only bad until you realize you can just say "cool story bro" and move on.

No change is always an acceptable response to review comments imo, unless it's one of mine.

If you can't defend that turd of a code unit, why the hell do you think it deserves to go into production?

save

path: 0 580877, hotness: undefined, score: 3, children: 1

Lenguador 1 point 3 years ago

Thanks for the advice, but I actually love code reviews.

save

path: 0 580877 589379, hotness: undefined, score: 1, children: 0

TechyShishy 2 points 3 years ago

"I don't understand what these two lines of code do, could you please modify, explain, or document." is very different from "I don't like the semantics of this function, replace it with this other one that does something unrelated."

We've worked at both places, and one is useful, the other... not so much.

save

path: 0 588096, hotness: undefined, score: 2, children: 0

V699 1 point 3 years ago

oof this is too real lol

save

path: 0 589859, hotness: undefined, score: 1, children: 0

MichaelobRegular 1 point 3 years ago

Not if you make your PR over 100 lines of code change in 1 commit. Then you get the good ol "LGTM" stamp

save

path: 0 572575, hotness: undefined, score: 1, children: 0

WalkableProgrammer 1 point 3 years ago