The eye-opener commit

3 years ago by Sucking Chest Wound to c/programmerhumor

lobut 136 points 3 years ago

I remember when I was working with .NET and I saw some web service code and I saw there was no try catches. They didn't have a global catch in the asax either or anything. I just wrapped each call into a try catch and log.

I got the same treatment where my manager wanted to know what happened with the increase in errors. I told him what I did. My manager got another developer to go through my commits regardless. I was a bit upset at the lack of trust.

path: 0 5529056, hotness: undefined, score: 136, children: 6
MotoAsh 49 points 3 years ago
path: 0 5529056 5531109, hotness: undefined, score: 49, children: 3
lobut 40 points 3 years ago

oh yeah I just logged and rethrew, so it shouldn't have had any behavior change, but I could have broken something I make mistakes all the time.

The errors we were seeing in logs were like logic or application errors that we just didn't see before. My changes really shouldn't have caused.

path: 0 5529056 5531109 5531559, hotness: undefined, score: 40, children: 2
AlboTheGuy 18 points 3 years ago

I think that was the right approach, then again didn't you have through a pull request or at least a code review? Knowing that would give raise to so many "errors" you should have had some sort of communication beforehand.

I don't blame you, more the workflow and ironically the manager

path: 0 5529056 5531109 5531559 5533065, hotness: undefined, score: 18, children: 1
lobut 12 points 3 years ago

Oh that was like years ago! Probably SVN, we on-boarded Git a little while after.

No pull requests, you just manually merged back then. It's definitely a workflow improvement we adopted later and we as a company and as an industry have gotten better.

lol, the thing was just that my manager asked me what I did and I told him. Him getting another dev to "fact-check" me after is what bothered me a bit. I am usually the type of look into issues rather than brush them off and I am the first to confess to a screw up. Which is why I was irked.

path: 0 5529056 5531109 5531559 5533065 5533183, hotness: undefined, score: 12, children: 0
magikmw 21 points 3 years ago

A manager that can't read a simple try catch commit? Why am I surprised.

path: 0 5529056 5529848, hotness: undefined, score: 21, children: 1
MonsiuerPatEBrown 31 points 3 years ago

they shouldn't have to do that. the commit log tells the manager who to go ask.

and since the developer did that to be a big swinging dick instead of bringing it up to the team in a meeting as a problem to address together the manager didn't trust them.

makes sense to people that have to manage other humans.

path: 0 5529056 5529848 5530653, hotness: undefined, score: 31, children: 0
hesusingthespiritbomb 75 points 3 years ago

Changing the error level in the build config without telling everyone and then making a hyperbolic passive aggressive comic when the senior admonishes you for doing so ?

I'm gonna guess 1 YoE, second job out of college. Enough experience to know what they're doing, but not enough to know when to do it.

path: 0 5529016, hotness: undefined, score: 75, children: 5
bouh 63 points 3 years ago

It's the delusion stage, when you think companies are places where you do professional work. Then you learn no one cares about properly doing your job. In fact, they'd rather you do not.

path: 0 5529016 5529166, hotness: undefined, score: 63, children: 2
Pringles 15 points 3 years ago

Ah, that hits close to home. I have spent a lot of time and energy to get my direct bosses onboard with following best practices and doing things right from the start. To their credit, they got onboard with it and are pushing that message themselves now. Of course, the board doesn't care about that and just jams random projects with strict deadlines without any thoughts given to the IT aspects of it up our asses, but our head of IT has apparently grown a spine and started pushing back, with some moderate success.

The MO of my company has for years been: do a POC and then as soon as it works, push that POC in production. I'm still cleaning up the mess of idiotic shit like that from 15 years ago.

path: 0 5529016 5529166 5533317, hotness: undefined, score: 15, children: 1
baltakatei 3 points 3 years ago

Ultimately, the quality of your work is a function of you and your resources. Corruption and miscommunication plague all management systems. Corrupt management siphons resources away from otherwise good work. Government bureaucracy is another layer of management like any other. Customers are not just consumers but working people like you.

Hang in there.

path: 0 5529016 5529166 5533317 5539972, hotness: undefined, score: 3, children: 0
AlboTheGuy 12 points 3 years ago

Tbh the fact that they were even ABLE to push something like that without anyone noticing is a red flag for the work environment and workflow.

path: 0 5529016 5533138, hotness: undefined, score: 12, children: 0
lukas 5 points 3 years ago
path: 0 5529016 5544949, hotness: undefined, score: 5, children: 0
phorq 55 points 3 years ago

I would normally put an if-statement before that to verify if IGNORANCE still equals BLISS

path: 0 5526918, hotness: undefined, score: 55, children: 0
db2 54 points 3 years ago

The second panel would be "No, I enabled error reporting. Those errors belong to just you."

path: 0 5530080, hotness: undefined, score: 54, children: 0
LazaroFilm 38 points 3 years ago

But it works fine on MY computer.

path: 0 5528359, hotness: undefined, score: 38, children: 6
cynar 49 points 3 years ago

"But we can't ship your computer!" and so Docker was born.

path: 0 5528359 5529824, hotness: undefined, score: 49, children: 5
MNByChoice 19 points 3 years ago

No, we cannot just put every random library on the server. Please stick to the stable ones the team picked, not random ones you just heard about and wanted to try in production.

Docker enters the chat: Now you can!

path: 0 5528359 5529824 5530167, hotness: undefined, score: 19, children: 4
xmunk 7 points 3 years ago

For some reason our executable only works if you include a jpg of a coconut... do you want to debug why or just ship it?

path: 0 5528359 5529824 5530167 5532949, hotness: undefined, score: 7, children: 3
MNByChoice 2 points 3 years ago

Shit that sounds familiar. Like the jpg was large enough to push the binary into some random memory region.

path: 0 5528359 5529824 5530167 5532949 5539771, hotness: undefined, score: 2, children: 0
MajorHavoc 2 points 3 years ago

Ship it!

path: 0 5528359 5529824 5530167 5532949 5535193, hotness: undefined, score: 2, children: 1
tsonfeir 28 points 3 years ago

Yay a PHP joke that isn’t making fun of PHP.

path: 0 5538557, hotness: undefined, score: 28, children: 0
mdhughes 24 points 3 years ago

"My project" doesn't exist in any team. It's everyone's project. A manager needs to have a long conversation with Pink Pants.

If you build your project at anything but highest error level, clang -Wall etc., you're letting errors in, relying at best on coincidence to work the way you think it does.

Commit it and don't revert it!

path: 0 5543983, hotness: undefined, score: 24, children: 0
cupcakezealot 23 points 3 years ago path: 0 5527293, hotness: undefined, score: 23, children: 1
SapientLasagna 3 points 3 years ago path: 0 5527293 5545407, hotness: undefined, score: 3, children: 0
Crul 19 points 3 years ago path: 0 5527130, hotness: undefined, score: 19, children: 3
BruceDoh 7 points 3 years ago

Certificate is expired

path: 0 5527130 5528572, hotness: undefined, score: 7, children: 2
Crul 5 points 3 years ago

Yep, that's why I added the twitter source too.

path: 0 5527130 5528572 5528739, hotness: undefined, score: 5, children: 1
Klear 8 points 3 years ago

Twitter is also expired.

path: 0 5527130 5528572 5528739 5531874, hotness: undefined, score: 8, children: 0
programmerhumor
programmerhumor

@lemmy.ml

login for more options
43751
1628
1186

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

  • Posts must be relevant to programming, programmers, or computer science.
  • No NSFW content.
  • Jokes must be in good taste. No hate speech, bigotry, etc.

go to feed...