13
24
twissell

@community.nodebb.org

twissell 3 points 7 months ago

@baris Great! So my observations and work were not in vain.

path: 0 22607939 22608005, hotness: undefined, score: 3, children: 1
twissell 2 points a year ago path: 0 19045376 19046908, hotness: undefined, score: 2, children: 0
twissell 2 points 21 days ago

@baris sure thing!

See it here

Review from Claude.AI

Look at these two lines in your post.tpl:

Line 14:  {{buildAvatar(posts.user, "48px", true, "", "user/picture")}}
          — rendered BEFORE the author scope opens (still inside the outer
            <li> from data/topic.tpl)

Line 19:  <div>

Line 27:  {{buildAvatar(posts.user, "20px", true, "", "user/picture")}}
          — rendered INSIDE that author/Person scope (it's the mobile-only
            duplicate avatar, class "d-sm-none")

Both calls render the exact same thing — posts.user's picture. NodeBB's avatar markup has historically stamped itemprop="image" directly onto the <img /> it generates (you can see this explicitly in older NodeBB themes, e.g. <img src="{posts.user.picture}" />), and buildAvatar() almost certainly carries that forward. That means:

Line 14's avatar sits outside the Person scope → its itemprop="image" attaches to the enclosing Comment scope → becomes comment.image
Line 27's avatar sits inside the Person scope → its itemprop="image" attaches there → becomes author.image

Same picture, same URL, two scopes → exactly the "should not have the same value" complaint.
```</div></li>
path: 0 25964548 25970874, hotness: undefined, score: 2, children: 0
twissell 2 points a year ago path: 0 19045376 19046931, hotness: undefined, score: 2, children: 0
twissell 1 point 21 days ago

Any thoughts?

path: 0 25962670, hotness: undefined, score: 1, children: 0
twissell 1 point a year ago

It seems this brakes Chat functionality (Firefox 143 & Chrome 141) for loggen in users. JS from Adsense conflicts with NodeBB core js files Can author check it on his side? The error is something like Service Worker cannot be register on specific conditions.

path: 0 19699774, hotness: undefined, score: 1, children: 0
twissell 1 point a year ago path: 0 19539467 19540423, hotness: undefined, score: 1, children: 1
twissell 1 point a year ago

julian thanks for response. So you literally meant there is no built-in feature(s) to do so? And I can accomplish this via custom plugin only.

path: 0 19748179, hotness: undefined, score: 1, children: 0
twissell 1 point a year ago

Theoretically, I found a workaround: disable advertisements only on the chat page. Can anybody tell me, how can I achieve this via custom code snippet and/or extension?

path: 0 19827200, hotness: undefined, score: 1, children: 0
twissell 1 point a year ago

baris issue has been solved. Thanks a ton!

path: 0 19863456 19932846, hotness: undefined, score: 1, children: 0
twissell 1 point 8 months ago path: 0 22066081, hotness: undefined, score: 1, children: 0
twissell 1 point 8 months ago

No, I meant sitemap files included in default main sitemap.xml. Not lastmod for the RSS feed. That kind of lastmod xml tags

path: 0 22320369, hotness: undefined, score: 1, children: 0
twissell 1 point 8 months ago

@baris what about adding lastmod for topics' sitemap? There is not much sense adding it for pages or categories, IMHO.

path: 0 22320649 22322777, hotness: undefined, score: 1, children: 0
twissell 1 point 8 months ago

> looking at every topic to get the most recent lastmod

That exactly what I meant! It's rather hard to implement with no significant performance degradation as far as I understand. Am I right?

path: 0 22324534, hotness: undefined, score: 1, children: 0
twissell 1 point 7 months ago

@baris thanks a lot feel free to chatting with me there!

path: 0 22607502 22607525, hotness: undefined, score: 1, children: 0
twissell 1 point 7 months ago

> @baris said: > > Are you still seeing the deleted tag when you load the topic page? What version of NodeBB are you using? If you can reliably reproduce let us know the reproduction steps

Yes and the second 'yes'. NodeBB version is latest stable 4.9.2

I login into admin panel Dashboard (Manage -> Tags), part by part delete all tags, BUT topics' tags persists. The resource is Bios-Doctor Forum. You may create and account then I'll grant you admin privileges, so you can see the problem firsthand. Firefox_Screenshot_2026-03-11T19-53-13.219Z.png

Firefox_Screenshot_2026-03-11T19-53-58.478Z.png

I can share any logs upon your request too :-)

Firefox_Screenshot_2026-03-11T19-53-13.219Z.png Firefox_Screenshot_2026-03-11T19-53-58.478Z.png

path: 0 22607067 22607455, hotness: undefined, score: 1, children: 0
twissell 1 point 7 months ago path: 0 22607577 22607776, hotness: undefined, score: 1, children: 0
twissell 1 point 7 months ago

Nice notion, thanks!

path: 0 22616149, hotness: undefined, score: 1, children: 0
twissell 1 point 4 months ago

@julian sure thing! Hope to see the fix in the next release. Thanks.

path: 0 24040350 24047960, hotness: undefined, score: 1, children: 0
twissell 1 point 18 days ago

Any updates?

path: 0 26025941, hotness: undefined, score: 1, children: 0

thanks for using Leebra!

go to feed...